Always initialize child-visible to FALSE, otherwise we may end up with the

2005-05-06  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtknotebook.c (gtk_notebook_insert_page_menu): Always
	initialize child-visible to FALSE, otherwise we may end up
	with the wrong page visible initially.  (#302283, Patrik Fimml)

	* gtk/gtktreeview.c (gtk_tree_view_draw_arrow): Make expanders
	appear insensitive in insensitive treeviews.

diff --git a/ChangeLog b/ChangeLog
index fbff06d3f6d34ea333761bf02606cd32582ae235..f13ed46251c4d718c3dc1a53b2615e18a1761afe 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2005-05-06  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtknotebook.c (gtk_notebook_insert_page_menu): Always
+       initialize child-visible to FALSE, otherwise we may end up
+       with the wrong page visible initially.  (#302283, Patrik Fimml)
+
+       * gtk/gtktreeview.c (gtk_tree_view_draw_arrow): Make expanders
+       appear insensitive in insensitive treeviews. 
+
+2005-05-05  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtktoolbar.c: Fix a typo in the docs.  (#303024, 
+       Morten Welinder)
+
 2005-05-06  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtk.symbols:

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index fbff06d3f6d34ea333761bf02606cd32582ae235..f13ed46251c4d718c3dc1a53b2615e18a1761afe 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,17 @@
+2005-05-06  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtknotebook.c (gtk_notebook_insert_page_menu): Always
+       initialize child-visible to FALSE, otherwise we may end up
+       with the wrong page visible initially.  (#302283, Patrik Fimml)
+
+       * gtk/gtktreeview.c (gtk_tree_view_draw_arrow): Make expanders
+       appear insensitive in insensitive treeviews. 
+
+2005-05-05  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtktoolbar.c: Fix a typo in the docs.  (#303024, 
+       Morten Welinder)
+
 2005-05-06  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtk.symbols:

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index fbff06d3f6d34ea333761bf02606cd32582ae235..f13ed46251c4d718c3dc1a53b2615e18a1761afe 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,17 @@
+2005-05-06  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtknotebook.c (gtk_notebook_insert_page_menu): Always
+       initialize child-visible to FALSE, otherwise we may end up
+       with the wrong page visible initially.  (#302283, Patrik Fimml)
+
+       * gtk/gtktreeview.c (gtk_tree_view_draw_arrow): Make expanders
+       appear insensitive in insensitive treeviews. 
+
+2005-05-05  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtktoolbar.c: Fix a typo in the docs.  (#303024, 
+       Morten Welinder)
+
 2005-05-06  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtk.symbols:

diff --git a/gtk/gtknotebook.c b/gtk/gtknotebook.c
index 412a8c530652f328a357b865bac1a50a5597f45b..ffe7f810fc8c76fff0d76eb12aa4c5978c93cba6 100644 (file)
--- a/gtk/gtknotebook.c
+++ b/gtk/gtknotebook.c
@@ -4371,10 +4371,8 @@ gtk_notebook_insert_page_menu (GtkNotebook *notebook,
   if (!notebook->first_tab)
     notebook->first_tab = notebook->children;
 
-  if (!notebook->cur_page)
-    gtk_widget_set_child_visible (child, TRUE);
-  else
-    gtk_widget_set_child_visible (child, FALSE);
+  /* child visible will be turned on by switch_page below */
+  gtk_widget_set_child_visible (child, FALSE);
   
   if (tab_label)
     {

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index 15172d745305364f5e1d4e8878a27c1d53204378..602077053a12d2df86094d8757725d37f8b71293 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -3236,12 +3236,15 @@ gtk_tree_view_vertical_autoscroll (GtkTreeView *tree_view)
 
   /* see if we are near the edge. */
   offset = y - (visible_rect.y + 2 * SCROLL_EDGE_SIZE);
+  g_print ("offset1 %d\n", offset);
   if (offset > 0)
     {
       offset = y - (visible_rect.y + visible_rect.height - 2 * SCROLL_EDGE_SIZE);
+      g_print ("offset2 %d\n", offset);
       if (offset < 0)
        return;
     }
+  g_print ("offset3 %d\n", offset);
 
   value = CLAMP (tree_view->priv->vadjustment->value + offset, 0.0,
                 tree_view->priv->vadjustment->upper - tree_view->priv->vadjustment->page_size);
@@ -8318,7 +8321,11 @@ gtk_tree_view_draw_arrow (GtkTreeView *tree_view,
   area.width = expander_size + 2;
   area.height = MAX (CELL_HEIGHT (node, vertical_separator), (expander_size - vertical_separator));
 
-  if (node == tree_view->priv->button_pressed_node)
+  if (GTK_WIDGET_STATE (tree_view) == GTK_STATE_INSENSITIVE)
+    {
+      state = GTK_STATE_INSENSITIVE;
+    }
+  else if (node == tree_view->priv->button_pressed_node)
     {
       if (x >= area.x && x <= (area.x + area.width) &&
          y >= area.y && y <= (area.y + area.height))